Padraig O'Briain wrote:
Brock,
When I applied this webrev there were two rejections.
src/packagemanager..py and
src/updatemanager.py
The problem with src/packagemanager.py was that you were trying to
change CLIENT_API_VERSION from 10 to 12 and revision 927 changed it
from 10 to 11.
In src/updatemanager.py you are trying to change CLIENT_API_VERSION
from 10 to 11 and revision 927 changed it from 10 to 11.
Should the CLIENT_API_VERSION be set to 12 in src/updatemanager.py?
It should be set to 12.
Brock
Padraig
On 03/10/09 07:44, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-2670-v2/
Here's the next webrev. It's synced with Shawn's putback, and covers
most of the comments that J and Bart had. One thing that hasn't gone
in yet are the comments that were requested. I plan to do those
tomorrow. It also moves all the files touched to have copyright 2009
on them.
Brock
Brock Pytlik wrote:
Someone mentioned this morning that they hadn't realized I'd put out
a webrev that was more than an FYI one. My apologies for being unclear.
Anyway, this is a real webrev (ie, it passes the test suite, has
been pylinted, and I've made an effort to cleanup and remove dead
code).
Specific things I still have questions remaining about:
Should I include/allow the -a/-p command options which duplicate the
functionality of putting '<>' or not around the entire query? Right
now, I'm leaning towards removing these options and simply relying
on <>. The reason for having -a/-p would be if we wanted to make
returning lists of packages the default behavior, and have users
have to specify -a to get the traditional behavior.
Also, right now I'm packaing ply up as part of SUNWipkg since it's
needed for the client, but not the server. If that's not the right
packaging approach to take, please let me know. I wasn't sure if I
should but it into a second package or not.
I thought there was going to be a longer list, but apparently that's
it at the moment.
The link is here:
http://cr.opensolaris.org/~bpytlik/ips-2670-v1/
The changes from prelim_search_v1_v6 are that I've fixed the server
response code used to something we've all agreed on I think (using
204 when a search matches nothing). Also, I removed a set of
unneeded changes in api.py, resynced with the gate and fixed a
couple of things for premptive windows compatibility. I moved from
ply-3.0 to ply-3.1. Last, I made a first pass at updating the man
page to reflect the new capabilities.
And here are the bugs which I'm addressing:
The umbrella bug is:
6175 search needs to be moved to version 1
http://defect.opensolaris.org/bz/show_bug.cgi?id=6175
Here are the individual bugs (which are also blockers for 6175):
2666 Search should support structured/field specific search
http://defect.opensolaris.org/bz/show_bug.cgi?id=2666
2667 Search should support boolean search
http://defect.opensolaris.org/bz/show_bug.cgi?id=2667
2668 Search should have a mode which only returns packages
http://defect.opensolaris.org/bz/show_bug.cgi?id=2668
2670 Client should get entire action from search
http://defect.opensolaris.org/bz/show_bug.cgi?id=2670
3238 failed searches no longer distinguished by HTTP response code
http://defect.opensolaris.org/bz/show_bug.cgi?id=3238
3338 Search needs a more flexible protocol to communicate during
remote searches
http://defect.opensolaris.org/bz/show_bug.cgi?id=3338
5874 Search API required
http://defect.opensolaris.org/bz/show_bug.cgi?id=5874
5967 indexer leaves open files
http://defect.opensolaris.org/bz/show_bug.cgi?id=5967
6170 remote search needs to validate server response
http://defect.opensolaris.org/bz/show_bug.cgi?id=6170
6173 versioned_urlopen breaks on cherrypy based servers
http://defect.opensolaris.org/bz/show_bug.cgi?id=6173
6287 search api should be able to send multiple queries in one
network transaction
http://defect.opensolaris.org/bz/show_bug.cgi?id=6287
6413 search should return which authority the response came from
http://defect.opensolaris.org/bz/show_bug.cgi?id=6413
6501 Case sensitive remote search should be allowed
http://defect.opensolaris.org/bz/show_bug.cgi?id=6501
6532 Search should allow control over the number, and starting
point, of results
http://defect.opensolaris.org/bz/show_bug.cgi?id=6532
6560 Consider making "pkg search -r" the default
http://defect.opensolaris.org/bz/show_bug.cgi?id=6560
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
