> The following webrev contains fixes for the following issues: > > 7277 client should use --help and -? options to show usage information > > webrev: > http://cr.opensolaris.org/~swalker/pkg-7277/
The code looks fine to me. The only question I have is why -? instead of -h? A lot of shells treat ? as a wildcard matching character and you have to remember to escape ?. It might be more straight-forward to use a single character that doesn't have to be escaped. Just as an example: $ ls -? ls: No match. $ ls -\? ls: illegal option -- ? usage: ls -aAbcCdeEfFghHilLmnopqrRsStuxvV1@ [files] Is it feasible to use -h, or do we have it in use for something else? -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
