John,
misc.py:
before line 66 please add empty line
line 66:
def display_help(application_dir=None, id=None):
should be:
def display_help(application_dir="", id=None):
otherwise you will add None to str which will fail on line 67.
updatemanager.py:
If you could change the copyright year to 2009.
Other then that it looks really nice!
best
Michal
jmr wrote:
Hi,
Here's a simple webrev that cleans up the GUI after feedback from Doc
and xDesign. These are needed for UI and Doc freeze for 06.2009. The
only remaining webrev to go in that has UI impact is the Search across
all repositories that will land after Brock's Search API webrev lands,
on which it depends. We plan to be UI and Doc frozen by cob Friday 13/03.
http://cr.opensolaris.org/~jmr/gui_cleanup_gate_105pm/
Bugs addressed:
6707 Text change for Update Manager dialog
6983 Dialog Layouts need rework
6985 Simplify Remove Confirm dialog
6987 Add Help Buttons
Issue:
Help - the help buttons on various dialogs just bring up the main Help,
we need link_id's from Doc to go to the relevant section. The code is in
place we will add the id's as soon as they are available. No impact on
UI or Doc freeze.
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
