On Thu, Mar 12, 2009 at 04:28:07PM -0600, Jerry Jelinek wrote:

>> I'll go ahead and ask why you don't do that for the first hunk as well,
>> though the answer I expect is that because you actually want to see the
>> message when it fails.  Except that you also print out $f_zfs_create, so
>> I'm not sure.
>
> Yes, I think we should fail if we really can't create the dataset and
> seeing the actual zfs error msg might help with troubleshooting in this
> case.

Maybe that information would be as useful in the loop case, too?  I'm not
sure which of the failure messages to print out there, though.  I don't
particularly care if you punt on that.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to