Dan Price wrote:
On Thu 12 Mar 2009 at 06:13PM, Jerry Jelinek wrote:
I updated the webrev at:

http://cr.opensolaris.org/~gjelinek/webrev.7304/

in case anyone else wants to check it out.

With ksh, I've usually used [[ $? -ne 0 ]] instead of (( )), which seems to
mostly be about actually doing arithmetic.

Otherwise, seems good.

Dan,

I used to do that myself but this is something
Roland complained about in a different code
review a while back and it is also something
that 'ksh -n' complains about, so I've been trying
to use this syntax instead.

Thanks for reviewing this,
Jerry

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to