* Shawn Walker <[email protected]> [2009-03-13 16:44]: > Shawn Walker wrote: >> Jerry Jelinek wrote: >>> I have a simple fix for bug: >>> >>> 5467 zoneadm install broken if zfs snapdir=visible >>> >>> The webrev is at: >>> >>> http://cr.opensolaris.org/~gjelinek/webrev.5467/ >>> >>> However, another option would be to reassign this >>> bug as a generic pkg bug and fix it in the base >>> pkging code. >> >> That would be bug 6419: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=6419 > > Actually, I take that back. Even though the same directory is causing > the issue in both cases, there's a subtle difference in the failure case > here. > > In the case of zoneadm, the failure is because the target directory > isn't empty (.zfs is present), so it's trying to be helpful and prevent > the user from creating an image a place they shouldn't. > > In the case of 6419, when we're looking for the image root, it finds it > in the .zfs directory causing problems since the "image" (backup really) > is readonly. > > I'm tempted to say that we should explicitly ignore the .zfs directory > during image operations instead when > portable.util.get_canonical_os_name() returns sunos. > > Any objections?
That sounds reasonable. There's also the behaviour seen in http://defect.opensolaris.org/bz/show_bug.cgi?id=1482 if you're poking at general handling for the sunos case. - Stephen -- [email protected] http://blogs.sun.com/sch/ _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
