Dan Price wrote:
Folks,
I have a wad of zones fixes for review. Codereview today would be most
appreciated if at all possible.
http://cr.opensolaris.org/~dp/pkg-zonefixes/
src/brand/pkgcreatezone:
lines 223-225: This is "splitting hairs", but: you can't set a
"preferred" repository; only a preferred publisher. In the future,
there will be multiple repositories per publisher, but only one can be
"selected" for packaging opeartions and only that one will be used for
the output of "pkg publisher".
line 258: Also need SUNWpython-ply, SUNWpython24-simplejson?
line 298: s/we're/we've/
Otherwise, looks fine.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
