Dan Price wrote:
Folks,I have a wad of zones fixes for review. Codereview today would be most appreciated if at all possible. http://cr.opensolaris.org/~dp/pkg-zonefixes/ Summary: - Fix a bunch of issues with authority/publisher Move to zoneadm install -p to specify publisher if needed. (instead of -a, but -a is preserved for compatibility for now). - Add ability to specify additional packages to be added to zone via '-e' argument. - A lot more sanity checking around our use of 'entire'. - Add ability to set ROOT for the build. i.e. you can now do: ROOT=/ python setup.py install (For zones, where we really need to test on the live system, this is super helpful).
Dan, This looks ok to me except I was wondering if you would mind changing the options you are using on pkgcreatezone. When I integrate p2v for ipkg branded zones (which I sent out for code review a few weeks ago but haven't gotten back to) then I'd like to be consistent with the existing p2v usage we already have for s8, s9 and native branded zones. That is, I'd like "-a" to specify the archive and "-p" to mean preserve the system identity. As part of the p2v wad I changed the existing "-a" to "-A". Would you mind doing that in your wad and changing "-p" to "-P"? Thanks, Jerry _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
