Danek Duvall wrote:
On Thu, Mar 19, 2009 at 01:10:15PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-7528-7529-v1/
indexer.py:
- line 560: Is there a reason that image isn't a keyword arg in the same
way that it is for _generic_update_index()?
Yep, it's a required argument for client_update_index, not an optional
one or one that has a sane default value.
- line 571: tmp_index_dir and image should probably be passed as
keywords, since that's how they're declared in _generic_update_index().
Ok.
search_storage.py:
- line 168: Why are you removing setting self._file_path to None on
close?
Because you need the path in order to be able to check whether the file
should be reread or not.
- line 671: This is unnecessary, since you'll just get an AttributeError
on the next line if it's something that evaluates to False.
Ok.
Danek
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
