On Thu, Mar 19, 2009 at 09:38:56PM -0700, Bart Smaalders wrote:
> http://cr.opensolaris.org/~barts/7547/
Just nits.
image.py:
- line 940: Remove space after quotes, capitalize first word in sentence.
I don't think you need the clause after the semicolon, either. End the
sentence with a period.
- line 943: Do you need the "if fmri" bit? Is a None entry in the
manifest cache a special case that you never want to remove?
manifest.py:
- line 83: Remove the spaces you added here.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss