Bart Smaalders wrote:
http://cr.opensolaris.org/~barts/7547/
http://defect.opensolaris.org/bz/show_bug.cgi?id=7547

modules/client/image.py:
  line 940: s/""" remove/"""remove/

  line 170: s/.  This/and delete from image cache as well.  This/

  line 171: s/  Delete from image cache as well.//

lines 943-945: why not try/except KeyError instead? Don't know which is faster...

modules/manifest.py:
  line 83: trailing whitespace added

line 741: could you expand on this comment a tiny bit? (such as "Special class for pkgplan used to stub out existing manifests", etc.)

  lines 742-743: is this even necessary since you subclass Manifest?

  line 749: extra newline?

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to