Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-2701-v1/
General comment; maybe scratch_area is better than writable-root, or is
this intended to be persistent storage? No strong preference here.
man/pkg.depotd.1m.txt:
lines 124, 189: s/-/_/ in property name to reflect pkg-server.xml and
for consistency with other options
line 124: s/The path to/The file system path to/ for consistency with
the description of other options.
modules/server/errors.py:
line 29: s/Transaction/server configuration/
line 33: I'd change this to "if args:" so that exceptions without
arguments can still use this base class.
tests/cli/t_pkg_depotd.py:
line 323: please add docstring explaining what test is intended to verify
Otherwise, seems fine.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
