Shawn Walker wrote:
Brock Pytlik wrote:
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-2701-v1/
General comment; maybe scratch_area is better than writable-root, or
is this intended to be persistent storage? No strong preference here.
It can be either, but my assumption was the generally it'd be permanent
storage since rebuilding the search indexes from scratch each time a
depot was restarted seemed like a bad idea.
man/pkg.depotd.1m.txt:
lines 124, 189: s/-/_/ in property name to reflect pkg-server.xml
and for consistency with other options
Fixed. As a general statement, I'd really like to see the name space
between the command line options and the svc properties unified. It
seems to me the simplest way of doing this is to add the '_' versions as
command line options and then support both '-' and '_' on the command
line, but I'm open to suggestions. More than once I've used the wrong
one of '_' and '-' and not understood why I wasn't seeing the behavior I
was expecting.
line 124: s/The path to/The file system path to/ for consistency
with the description of other options.
modules/server/errors.py:
line 29: s/Transaction/server configuration/
line 33: I'd change this to "if args:" so that exceptions without
arguments can still use this base class.
Changed to:
if args:
self.data = args[0]
else:
self.data = None
tests/cli/t_pkg_depotd.py:
line 323: please add docstring explaining what test is intended to
verify
Otherwise, seems fine.
Cheers,
Thanks for taking a look,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
