Danek Duvall wrote:
On Tue, Mar 31, 2009 at 11:15:20PM -0500, Shawn Walker wrote:
So retrieving the license information at the same point we retrieve
manifests would seem reasonable?
In a real install context -- i.e., not install -n, not contents or info.
I didn't intend it for contents or info, but in the case of install -n,
would that mean we would only display a generic license failure message
if some licenses required acceptance and the user didn't provide the
acceptance somehow?
That's an interesting (and preferable) approach. That is, instead of
loading the license text, having each exception provide either an opener()
that returned a file object to stream the content, or providing the path to
the file itself. In either case, I would expect a str() of the exception
to have the same effect.
What, effect, exactly? Displaying the license? I think that's putting way
too much smarts into the __str__() methods. We're doing more work in
exception classes than we should I think, but this seems more excessive
than the rest to me. But perhaps I've misunderstood your intent.
No, you understood correctly. It sounds like an opener() would be
preferable.
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
