Danek Duvall wrote:
On Tue, Apr 14, 2009 at 07:48:18PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-6251-v1/
line 937, others: space after colon
line 960: no need to do the string conversion of "e" twice.
line 1050: two spaces after "for"
line 1061: I might get rid of this setting of retcode (and on 1066), and
have an else clause after line 1073 that sets it to 0.
It can't be in the else clause (as I found out during testing, b/c then
an empty result returns 0 instead of 1). How about I pull them out (and
the first = False lines) and put them on line 1061 and 1062, still
inside the loop but out of the if clause starting on line 1061?
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
