On Thu, Apr 16, 2009 at 01:09:38AM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-2557/
Looks good, generally.
Could you post the first dozen or so lines of your new cache file, or put
it up on cr.os.o?
catalog.py:
- Do we really need both cache_fmri() and fast_cache_fmri()? If nothing
else, since they're both building up the same structure, there's no
reason to duplicate the docstring. And cache_fmri() could do the
pre-chewing necessary to just use fast_cache_fmri(), no?
image.py:
- line 1666: could publist be a set?
- line 1716: you might comment here that the "pubs" that was passed in is
no longer necessary, so we're re-using the name.
- line 1724: would it help to just convert the number to a string here,
so you don't have to do it repeatedly later on?
- line 1758: "are comprised of" -> "are made up of".
- line 1759: strike the comma
- line 1760: "or it" -> "or where it"?
- line 1780: might it not be simpler to just use +:
line = sfmri + "|" + known + "!" + unknown
- line 1868: Would this be too crazy: "for lnum, line in enumerate(f):"?
Or even
for lnum, line in (i + 3, l.strip() for i, l in enumerate(f)):
t_pkg_list.py:
- line 362,363: delete
- line 389: Is "VESRION" on purpose, to make it extra invalid?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
