Brock Pytlik wrote:
...

Only other thing I can think of to test against would be malformed cache file lines (a line that expects a previous full fmri to have been given as the first line after the publisher line for example, or lines that are just truncated in their middles). Not sure if that's necessary or not, probably not, but it was the only thing I couldn't see being tested.

Nice catch, I've added a test case and put in some code to handle this case.

Also, I did some memory profiling comparing the total amount of anonymous memory reservations in bytes by "pkg -R / info nosuch" using Brendan's anonprofile.d script:

flat file catalog_cache: 41,758,720
cpickle catalog_cache 119,336,960

I think that's a decided improvement :)

I'll putback shortly.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to