Just profiled this and it costs < 0.001 sec at start up to set things up
in __setup_startpage() if the user has chosen not to show the start page
on start up (no load page), so happy to leave as is.
JR
Padraig O'Briain wrote:
That sounds a good enough reason for me.
Looks good to me.
Padraig
On 04/30/09 07:30, jmr wrote:
Padraig O'Briain wrote:
Just one question.
In __setup_startpage if show_startpage is false is it necessary to
do the work that is done before show_startpage is tested?
Well - its doing the setup here so we get a nice fast display of the
Start Page if the user chooses the option from the View menu, but I
will profile it and see if it makes sense to delay this initial setup
as well.
JR
Padraig
On 04/30/09 02:38, Takeshi Asano wrote:
Hi John,
Thank you. It looks good to me.
Takeshi
On 2009年04月30日 06:01, jmr wrote:
In order to better support l10n we need to enhance the logic for
detecting start_page.html for locales, so it falls back from
locale to locale-root to C locale, so for German it would check in
order:
/usr/share/package-manager/data/startpagebase/de_DE/startpage.html
/usr/share/package-manager/data/startpagebase/de/startpage.html
/usr/share/package-manager/data/startpagebase/C/startpage.html
Previously it was just falling back from locale to C locale.
http://cr.opensolaris.org/~jmr/pm_8526_locale_startpage_29April_10pm/
8526 PM locale start_page detection needs enhanced
I also noticed a redundant start page load when the user is not
displaying start page on start up, that I have eliminated.
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
