There is a bug in the default gconf key, it should not be in quotes. If
it is the update will fail. Removing the quotes for
/apps/packagemanager/preferences/startpage_url is all that's needed.
http://cr.opensolaris.org/~jmr/pm_8526_locale_startpage_30April_355pm/
JR
jmr wrote:
Reviewed and tested with Padraig, doing some unnecessary checking when
updates up to date already, instead of exiting. New webrev:
http://cr.opensolaris.org/~jmr/pm_8526_locale_startpage_30April_335pm/
JR
jmr wrote:
Padraig when I was reviewing and testing, I realized
update-refresh.sh should also be modified to obey the same logic when
testing for download updates to the start pages. The webrev below
does this in addition to supporting the logic in PM at runtime..
http://cr.opensolaris.org/~jmr/pm_8526_locale_startpage_30April_12noon/
For instance if locale is de_DE (taken from /etc/default/init) it
will try and fetch updates in this order:
de_DE -> de -> C:
/apps/packagemanager/preferences/startpage_url
Download from: http://localhost (specified in PM gconf key
/apps/packagemanager/preferences/startpage_url)
To cache dir: /var/pkg/gui_cache/startpagebase
http://localhost/startpagebase-de_DE.tar.gz
http://localhost/startpagebase-de.tar.gz
http://localhost/startpagebase-C.tar.gz
At runtime PM will attempt to load the start page from the cache in
the order:
/var/pkg/gui_cache/startpagebase/de_DE
/var/pkg/gui_cache/startpagebase/de
/var/pkg/gui_cache/startpagebase/C
Then it will try from the install dir:
/usr/share/package-manager/data/startpagebase/de_DE
/usr/share/package-manager/data/startpagebase/de
/usr/share/package-manager/data/startpagebase/C
JR
Padraig O'Briain wrote:
That sounds a good enough reason for me.
Looks good to me.
Padraig
On 04/30/09 07:30, jmr wrote:
Padraig O'Briain wrote:
Just one question.
In __setup_startpage if show_startpage is false is it necessary to
do the work that is done before show_startpage is tested?
Well - its doing the setup here so we get a nice fast display of
the Start Page if the user chooses the option from the View menu,
but I will profile it and see if it makes sense to delay this
initial setup as well.
JR
Padraig
On 04/30/09 02:38, Takeshi Asano wrote:
Hi John,
Thank you. It looks good to me.
Takeshi
On 2009年04月30日 06:01, jmr wrote:
In order to better support l10n we need to enhance the logic for
detecting start_page.html for locales, so it falls back from
locale to locale-root to C locale, so for German it would check
in order:
/usr/share/package-manager/data/startpagebase/de_DE/startpage.html
/usr/share/package-manager/data/startpagebase/de/startpage.html
/usr/share/package-manager/data/startpagebase/C/startpage.html
Previously it was just falling back from locale to C locale.
http://cr.opensolaris.org/~jmr/pm_8526_locale_startpage_29April_10pm/
8526 PM locale start_page detection needs enhanced
I also noticed a redundant start page load when the user is not
displaying start page on start up, that I have eliminated.
JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
