Danek Duvall wrote:
On Tue, Jun 02, 2009 at 05:35:20PM -0500, Shawn Walker wrote:

Yes.  Whenever we publish a manifest, the first line that the server
always writes to a file is a comment.  It is automatically done as
part of publication.

That seems like an implementation detail that we might not want to rely on
in quite so subtle a way.  Perhaps we already are doing so in some other
place, though?

Not that I know of.

However, remember that this is a short-term fix. Because of time and other constraints, pkgrecv currently uses actual publishing operations to add the manifest and its files to the repository.

That won't work long-term, especially once package-signing is put into place.

My long-term fix is to add a special manifest operation that uploads the manifest as is, and then adds the content to the repository and "republishes it" instead of the "sort-of-a-hack" republication process I'm using now for pkgrecv.

Once that's done, there won't be a need for the comment parsing I'm doing now as I can guarantee that the manifest will be exactly as it was received.

Cheers,

--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to