Brock Pytlik wrote:
Rich Burridge wrote:
4395 Use pkg.summary for "pkg info" output
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=4395
8829 solaris.py should be able to add pkg.summary attributes
Bugid: http://defect.opensolaris.org/bz/show_bug.cgi?id=8829
Last message:
http://mail.opensolaris.org/pipermail/pkg-discuss/2009-May/013515.html
Last webrev: http://cr.opensolaris.org/~richb/pkg-4395-8829-v2/
Ack! That should have been:
Last webrev: http://cr.opensolaris.org/~richb/pkg-4395-8829-v3/
Sorry about that.
Can you double check that this passes the test suite?
It does.
Specifically, I'm not sure how test_info_local_remote in t_api_info is
passing the test at line 181, but your change suggests that it shouldn't.
It'll work because if a package transaction doesn't specifically have a
pkg.summary line such as:
add set pkg.summary='SOME FOOO bAr O OO OOO SUMMARY'
it'll fallback to using the package "description" line for backward
compatibility.
See the code at lines 796-797 in:
http://cr.opensolaris.org/~richb/pkg-4395-8829-v4/src/modules/client/api.py.wdiff.html
The pkg in the test suite only has description set, and not summary,
so I'm unclear as to how anything is coming back from the API call. In
any case, I'd like to see the tests in both t_api_info and t_pkg_info
augmented to check that the new info is both returned, and displays,
correctly.
Could you be more specific please. Knowing that it'll now fall back to the
"description" lines, what changes to what tests in what files would you
like
to see?
The change itself in api.py looks fine to me. You might consider
breaking out of the loop after setting summary, but that's a minor nit.
Yup. Shawn said the same thing. So changed. New webrev at:
http://cr.opensolaris.org/~richb/pkg-4395-8829-v4/
The changes in solaris.py look fine to me, though I'm curious is the
section from 706-726 is the section that's turning "summary" into
"pkg.summary".
It's the code at lines 744-748 in:
http://cr.opensolaris.org/~richb/pkg-4395-8829-v4/src/util/distro-import/solaris.py.wdiff.html
for the latest webrev.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
