Rich Burridge wrote:
[snip]
Thanks for clearing up my confusion about the fall back behavior, the
version I was looking at didn't have it in there :)
The pkg in the test suite only has description set, and not summary,
so I'm unclear as to how anything is coming back from the API call.
In any case, I'd like to see the tests in both t_api_info and
t_pkg_info augmented to check that the new info is both returned, and
displays, correctly.
Could you be more specific please. Knowing that it'll now fall back to
the
"description" lines, what changes to what tests in what files would
you like
to see?
I'd like to see a test case that didn't depend on the fall back behavior
to succeed, so a test where summary was set. I'd also like to see one
where both description and summary were set to make sure the right
choice is made.
The changes in solaris.py look fine to me, though I'm curious is the
section from 706-726 is the section that's turning "summary" into
"pkg.summary".
It's the code at lines 744-748 in:
Great, thanks.
Other than the test cases mentioned above, LGTM.
Brock
http://cr.opensolaris.org/~richb/pkg-4395-8829-v4/src/util/distro-import/solaris.py.wdiff.html
for the latest webrev.
Thanks.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
