On Jun 16, 2009, at 3:21 PM, [email protected] wrote:
On Tue, Jun 16, 2009 at 02:27:16PM -0500, Shawn Walker wrote:
On Jun 11, 2009, at 2:52 PM, Shawn Walker wrote:
Greetings,

The following webrev contains fixes for the following issue:

8616 operations should use same publisher when only non-preferred has
package

webrev:
http://cr.opensolaris.org/~swalker/pkg-8616/

In short, this fixes make_install_plan's behaviour so that when two
non-preferred publishers are the only ones that offer a dependency,
that the same publisher as the package that declared the dependency
will be checked first for the dependency.


Hi, still need reviewers for this changeset.

This looks good.



I just realised that I also needed a test to ensure that if you named a package and all of its dependencies with explicit publishers for install that those publishers should be used regardless of this logic.

I added a unit test for it, but no other code changes were needed (thankfully):

updated webrev:
http://cr.opensolaris.org/~swalker/pkg-8616-2/

diff from last webrev:
http://cr.opensolaris.org/~swalker/pkg-8616-2/v1-v2.patch

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to