On Jun 16, 2009, at 8:05 PM, [email protected] wrote:
On Tue, Jun 16, 2009 at 06:55:15PM -0500, Shawn Walker wrote:
I just realised that I also needed a test to ensure that if you named a package and all of its dependencies with explicit publishers for install
that those publishers should be used regardless of this logic.

I added a unit test for it, but no other code changes were needed
(thankfully):

updated webrev:
http://cr.opensolaris.org/~swalker/pkg-8616-2/

diff from last webrev:
http://cr.opensolaris.org/~swalker/pkg-8616-2/v1-v2.patch

I took a look at your patch, and everything looks in order.  For a
revision of this magnitude, I'm not sure I'd bother to send out another
review.  Although, nobody can fault you for being diligent, or honest,
about the process. :)


Thanks; putback.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to