Hello Danek,
Currently I am preparing two webrevs which will allow to run automated tests for the PM. First one[0] is to include required LDTP[1] package in the IPS Gate and second one[3] is to include all files to run automated tests using LDTP.

I have few questions related to the first webrev as it is not working perfectly.

- I had to write ldtp.sh shell script, which is invoked by the src/gui/Makefile to download, unpack, run few configure commands and build ldtp package. The problem is that a lot of extra information is printed during build. Should we redirect this to some /tmp/ldtp_build.log file and just print few nice informative strings?

- The ldtp package requires few extra packages to be installed on the system in order to build it. Currently ldtp.sh script is checking for those and if they are not installed it is printing error message to the user. Should we automatically install those packages for the user? Or maybe we should ask the user if those packages should be installed with timeout 10s (by default install them)?

- After running make install && make packages the "check" part of the src/pkgdefs/Makefile script is comparing for what is on the system and what is in the protoproto file. Am I correct? I have few problems with this comparison, because we do not control Makefile from the ldtp tarball, but first I need to understand what is it doing exactly. Is there any environment variable which tells where we want to install those IPS packages (aka DESTDIR) ?

Those are commands which I am using to build ldtp package:

hg clone ssh://[email protected]/hg/pkg/gate ldtp_integration_v1
cd ldtp_integration_v1
wget http://cr.opensolaris.org/~migi/include_ldtp_v3/include_ldtp_v2.patch
gpatch -p1 < include_ldtp_v2.patch
rm include_ldtp_v2.patch
cd src
chmod 755 gui/ldtp.sh
export PATH=/usr/sbin:/opt/SunStudioExpress/bin:/usr/ccs/bin:/usr/gnu/bin:/usr/bin:/usr/X11/bin:/sbin:/usr/sfw/bin
rm -rf ../packages/ ../proto/ && make  && make packages

[0] http://cr.opensolaris.org/~migi/include_ldtp_v3/
[1] http://ldtp.freedesktop.org/wiki/
[2] http://cr.opensolaris.org/~migi/automated_tests_ldtp_v1/

best
Michal Pryc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to