Michal gave me a call today to wring the answers out of me ... :) Here are the answers I gave him.
On Wed, Jun 17, 2009 at 12:20:52PM +0200, Michal Pryc wrote: > - I had to write ldtp.sh shell script, which is invoked by the > src/gui/Makefile to download, unpack, run few configure commands and build > ldtp package. The problem is that a lot of extra information is printed > during build. Should we redirect this to some /tmp/ldtp_build.log file and > just print few nice informative strings? No, it should be printed out. Of course, incremental builds shouldn't need to do anything here, and should thus be quiet. It might be nice, though to put the "noise" up on cr.o.o to see how crazy, exactly, it is. > - The ldtp package requires few extra packages to be installed on the > system in order to build it. Currently ldtp.sh script is checking for those > and if they are not installed it is printing error message to the user. > Should we automatically install those packages for the user? Or maybe we > should ask the user if those packages should be installed with timeout 10s > (by default install them)? Like Shawn said, no, don't install anything. We already require pyopenssl to be on the system for proper operation. Though I'd like some more information here -- what packages does ldtp need, and should they be part of the WOS? > - After running make install && make packages the "check" part of the > src/pkgdefs/Makefile script is comparing for what is on the system and what > is in the protoproto file. Am I correct? No, it's checking the contents of the proto area against the contents of the combined prototype files. We'll get an error during pkgmk if a file listed in a prototype file isn't in the proto area, and this check is doing the opposite -- if a file is in the proto area and isn't listed in any prototype file, there's a bug. Either it needs not to be in the proto area after "make install" or it needs to be in a prototype file. This is a very simple version of "protocmp", for those who are familiar with ON and SFW build procedures. I'll take a look at the patches next week. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
