On Jun 19, 2009, at 9:06 PM, Brock Pytlik wrote:
This wad fixes some of the current error hiding that happens. In the
test suite, if we start getting unexpected index rebuilds, the test
suite will fail that test. The error messaging to users has also
been improved so that if an exception happens during indexing which
we can't recover from, we notify the user of the error, but then
inform them that the install/uninstall/image-update succeeded
despite the error while updating the index.
Webrev:
http://cr.opensolaris.org/~bpytlik/ips-8948-v1/
Bugs:
8948 search errors should make it clear that the rest of the command
worked
http://defect.opensolaris.org/bz/show_bug.cgi?id=8948
7534 Need to check when auto-reindex happens in test suite
http://defect.opensolaris.org/bz/show_bug.cgi?id=7534
client.py:
lines 2596, 2597: doesn't this mean that setlocale() and
gettext.install() can happen multiple times in a wrapped error case?
It seems like these might belong in if __name__ == "main" with
appropriate try/except wrappers
modules/client/api_errors.py:
lines 611, 628: missing ',' at end
line 629, 630: running or performing?
modules/client/imageplan.py:
line 116: should this be a public or private property? If nothing
needs access to this outside the imageplan class, please make it
private. Does it even need to be a property?
tests/cli/_api_search.py:
line 1659: needs short docstring summarising what test is doing
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
