Shawn Walker wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-8948-v1/
...
One question that occurred to me when I looked over this code again is how you want history to handle this case. I believe that if the main operation reported success, that's what the history should record.

The better option here is to start a new operation for the indexing, and then do a log_operation_end(error=indexing_exception) and add an appropriate failure code to history.py's exception table for that exception.

That allows the image-update to logged as succeeding, but the indexing as failing.

I do the same thing with catalog refreshes now ...

Cheers,
Ok, I'll file a bug to improve history's handling of indexing errors.

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to