On Thu, Jun 25, 2009 at 07:51:08PM -0700, Bart Smaalders wrote:
> http://cr.opensolaris.org/~barts/9509/
publish.py:
- line 87, 89: I'd just have a single copy of "[-d basedir]" and mention
in the description of it in the man page that it can be specified
multiple times. This just looks weird.
- line 214: "[opt, arg]"
- line 215: "if not pargs:"
- line 220: scrap the comment
- line 272: since you do this later, too, you could create the action
before the test of args[0], and add the data on later. Of course, we
don't have a good interface for that, but we could add one. You can do
that if you like, but otherwise, perhaps file an RFE?
- line 273: don't need None here.
- line 274: don't you *always* get this for a license action?
- line 276: four-space indent
- line 279: Why aren't you using the MalformedActionError printout
routine here, rather than building your own? You only need to add the
line number. Plus, you're not handling the other ActionError
subclasses, which would probably be very useful here.
- line 302: no need for the backslash.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
