Danek Duvall wrote:

  - line 272: since you do this later, too, you could create the action
    before the test of args[0], and add the data on later.  Of course, we
    don't have a good interface for that, but we could add one.  You can do
    that if you like, but otherwise, perhaps file an RFE?

#9721




  - line 274: don't you *always* get this for a license action?


yes... so right now you have to replace NOHASH w/ a path to the local
file for license actions.

  - line 279: Why aren't you using the MalformedActionError printout
    routine here, rather than building your own?  You only need to add the
    line number.  Plus, you're not handling the other ActionError
    subclasses, which would probably be very useful here.


Done; that's cleaner, thanks.

- Bart



--
Bart Smaalders                  Solaris Kernel Performance
[email protected]         http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to