Padraig O'Briain wrote:
Should similar changes be made for Update Manager and use of
progressdialog in beadm and repository dialog.
I will look at beadm, but I don't think we want to do those changes for
UM. Will discuss this with Jenya.
I have noticed that when I press Reload there is a dotted line (like a
focus indicator) around the area where the package list is displayed
while the reload is happening. I do not see this if I run package
manager from the gate.
What build of OpenSolaris are you using?
111b, I don't see this problem on my computer. I will update to 117 and
check this.
You remove lines 3 and 4 of packagemanager.glade which I believe John
added recently.
Most of the changes in packagemanager.glade seem to be like that: i.e.
undoing of changes John did recently which have nothing to do with the
the changes you made.
This makes it very difficult to review the changes. Can you make these
changes on build 117 so we do not have this problem?
Sure. I was just using glade file to add new widgets, so I am not sure
why this happened, but I will double check that only my changes are in
the next webrev.
packagemanager.py:
You removed some constants at the start of the file. Should the
comments at lines 26 to 33 be changed or removed?
Yes.
What is the purpose of __on_main_window_check_resize?
Currently it is required to have layered gdk.Window on top of the
gtk.Window, which is PM main window to allow busy cursor to work. This
prevents user to mouse click on the widgets, but the progress in the
status bar may have cancel button (which is currently hidden, but it
exists). So we need to adjust size of the gdk.Window to allow user to
mouse click in the status bar area. This function checks the size of the
gtk.Window and if this size is changed it also adjusts the size of
layered gdk.Window, so the status bar is always clickable.
I ran pylint on packagemanager.py and it threw up some errors and
warnings. Can you fix these?
Will do.
best
Michal Pryc
On 07/13/09 16:47, Michal Pryc wrote:
Hi,
Over the phone Padraig told me that this webrev do not apply cleanly
to the gate.
Cleanly applying webrev:
http://cr.opensolaris.org/~migi/progress_in_statusbar_13_Jul_v1/
best
Michal
Michal Pryc wrote:
Hi,
Bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=6972
CR:
http://cr.opensolaris.org/~migi/progress_in_statusbar_13_Jul/
Currently instead of progress dialog the progress for
loading/refreshing catalog is in statusbar. The position of this
progress is still subject to change, but the logic will stay.
Also there is hidden cancel button. When the api will allow us to
use cancel for search, the user will be able to click on this cancel
button. That is why we need lines:
457-458 and related function in the packagemanager.py.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
