Padraig,
New webrev:
http://cr.opensolaris.org/~migi/progress_in_statusbar_15_Jul_v1/
Comments inline.
Padraig O'Briain wrote:
Should similar changes be made for Update Manager and use of
progressdialog in beadm and reposit
Currently no, if we want to it's separate bug.
ory dialog.
I have noticed that when I press Reload there is a dotted line (like a
focus indicator) around the area where the package list is displayed
while the reload is happening. I do not see this if I run package
manager from t
I have tried this on build 118 and I don't see this behaviour. (I
couldn't reproduce this on 111b)
he gate.
What build of OpenSolaris are you using?
First I was using 111b, but this webrev is prepared using latest 118.
You remove lines 3 and 4 of packagemanager.glade which I believe John
added recently.
Most of the changes in packagemanager.glade seem to be like that: i.e.
undoing of changes John did recently which have nothing to do with the
the changes you made.
This makes it very difficult to review the changes. Can you make these
changes on build 117 so we do not have this problem?
I've just merged necessary glade changes, so now it should be straigh
forward.
packagemanager.py:
You removed some constants at the start of the file. Should the
comments at lines 26 to 33 be changed or removed?
Removed.
What is the purpose of __on_main_window_check_resize?
I did explain in the previous e-mail.
I ran pylint on packagemanager.py and it threw up some errors and
warnings. Can you fix these?
Fixed. Now it's 10.0/10.0.
best
Michal Pryc
On 07/13/09 16:47, Michal Pryc wrote:
Hi,
Over the phone Padraig told me that this webrev do not apply cleanly
to the gate.
Cleanly applying webrev:
http://cr.opensolaris.org/~migi/progress_in_statusbar_13_Jul_v1/
best
Michal
Michal Pryc wrote:
Hi,
Bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=6972
CR:
http://cr.opensolaris.org/~migi/progress_in_statusbar_13_Jul/
Currently instead of progress dialog the progress for
loading/refreshing catalog is in statusbar. The position of this
progress is still subject to change, but the logic will stay.
Also there is hidden cancel button. When the api will allow us to
use cancel for search, the user will be able to click on this cancel
button. That is why we need lines:
457-458 and related function in the packagemanager.py.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
