Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-10141-v1/, fixes
10141 Wrong file saved in GUI cache

This error was caued by the changest 1232, which added the text "All Sources (Search Only)" to the repository combobox. The fix is to check for this string in __remove_cache.

Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
It strikes me as a bit dangerous to check one translated string against another for equality when they've been translated two separate times. Maybe but the strings "Add..." and "All Sources (Search Only)" in common variables so they're translated once, then compare them here? It seems like that would be safer (also against possible rewording/naming changes), but maybe I just don't understand something.

Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to