Looks, ok, but I would change the logic:
2500 + if (pub_name and
2501 + pub_name !=
self.publisher_options[PUBLISHER_ADD] and
2502 + pub_name !=
self.publisher_options[PUBLISHER_ALL]):
to:
if pub_name and pub_name not in self.publisher_options.values():
Michal
Padraig O'Briain wrote:
I spun a later version of the webrev,
http://cr.opensolaris.org/~padraig/ips-10141-v2/, in response to Brock
who made essentially the same comment as you have.
Padraig
On 07/21/09 11:42, Michal Pryc wrote:
LGTM
One idea, maybe it make more sense to have those two strings in the
table?
> combobox = [_("Add"), _("All Sources (Search Only)")]
then instead of:
2495 + if pub_name and (pub_name !=
_("Add...") and
2496 + pub_name != _("All Sources
(Search Only)")):
we would have:
if pub_name and pub_name not in combobox:
do the stuff....
what do you think?
best
Michal
Padraig O'Briain wrote:
The webrev, http://cr.opensolaris.org/~padraig/ips-10141-v1/, fixes
10141 Wrong file saved in GUI cache
This error was caued by the changest 1232, which added the text "All
Sources (Search Only)" to the repository combobox. The fix is to
check for this string in __remove_cache.
Padraig
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
