On Mon, Aug 03, 2009 at 02:13:56PM -0700, Danek Duvall wrote:
> On Mon, Aug 03, 2009 at 01:50:26PM -0700, [email protected] wrote:
> 
> > Folks,
> > I have another small code review.  This fixes a couple of transport
> > issues, a traceback in the CLI, and provides more information when we
> > fail assertions in the progress tracker.  The total change here is less
> > than 100 lines.
> > 
> >     http://cr.opensolaris.org/~johansen/webrev-10411/
> 
> progress.py:
> 
>   - Is the base ProgressTracker class the right place to put messaging?  I
>     would expect this to go in FancyUNIXPT and CommandLinePT, but not the
>     others.  This raises the question of whether FUPT should inherit from
>     CLPT.

Given that the traceback from failing the assertion is going to go to
stderr, I assumed that it wouldn't be a problem to have the actual
numbers get printed there too.  Am I missing something?

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to