[email protected] wrote:
Folks,
I have another small code review. This fixes a couple of transport
issues, a traceback in the CLI, and provides more information when we
fail assertions in the progress tracker. The total change here is less
than 100 lines.
http://cr.opensolaris.org/~johansen/webrev-10411/
src/modules/client/progress.py:
line 183: extra newline?
lines 185-194: I don't think the ProgressTracker class should be
calling emsg(). That will cause the Null and Quiet classes to output
when there's an error (which I don't think should happen). I think this
should be in an override in FancyUNIXProgressTracker and
CommandLineProgressTracker. Note that the GUI client inherits from
NullProgressTracker as well, and the emsg() would typically never be seen.
src/modules/client/transport/engine.py:
line 644: I'm feeling a bit dumb; why does having completed as a
engine level property work given that commit() is called on a
per-handled basis?
line 646: extra newline?
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
