Danek Duvall wrote:
So I did a bit of work a little while ago to see what it would take to get
us running under Python 2.6 (note: just running, not using any of its new
features, but also not worrying about compatibility with 2.4).

With the exception of some of the dependency analysis tests, I have a
preliminary patch that lets us pass the testsuite.

    http://cr.opensolaris.org/~dduvall/pkg-python26/

The unresolved issues are:

  - The version of CherryPy we use doesn't support 2.6.  I believe the next
    micro version does, but I'm not sure how safe that is.  So I added a
    patch to munge our version to at least run under 2.6.  I think
    upgrading is probably safer, but wanted Shawn to weigh in.

I think upgrading to 3.1.2 is safer, although your patch looks almost exactly the same as theirs:

http://www.cherrypy.org/changeset/2104

The main fixes I see in 3.1.2 for us are:

* ability to raise custom errors with custom reason phrases (e.g. "404 No Search Results") (http://www.cherrypy.org/ticket/898)

* python 2.6 compatibility

* encoding issues fixes (http://www.cherrypy.org/changeset/2238)

* some socket and transport fixes

  - As part of the publication process, we use a module, xml.dom.ext.reader,
    which is no longer available in 2.6 in Solaris.  My hack solution was
    to download and build pyxml as part of the process, but I think the
    right answer is to use the built-in htmllib methods, if feasible.
    Perhaps we should simply ask that the server not spit HTML back at us.
    Either way, this is Shawn's code, and he should at least weigh in on
    what the solution should be.

The solution is likely the custom reason phrases I mentioned above.

Your changeset looks fine overall.

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to