Hi Dan,
On Thu, Aug 13, 2009 at 05:09:41PM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/pkg-rafsrevenge/
Just a couple of questions:
pkgsubprocess.py:
- line 79: Would it make sense to switch from a list to a set? This
would prevent you from getting duplicate fds in the list. I'm not
sure it matters here, but I thought I'd mention it.
pspawn.c:
- line 205 & 210: Do you want to define a default value for startfd?
Or should the caller always know this ahead of time.
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
