On Thu 13 Aug 2009 at 05:23PM, [email protected] wrote:
> Hi Dan,
>
> On Thu, Aug 13, 2009 at 05:09:41PM -0700, Dan Price wrote:
> > http://cr.opensolaris.org/~dp/pkg-rafsrevenge/
>
> Just a couple of questions:
>
> pkgsubprocess.py:
>
> - line 79: Would it make sense to switch from a list to a set? This
> would prevent you from getting duplicate fds in the list. I'm not
> sure it matters here, but I thought I'd mention it.
Ok. I think given the tiny size here, I'd like to leave it.
> pspawn.c:
>
> - line 205 & 210: Do you want to define a default value for startfd?
> Or should the caller always know this ahead of time.
I think the caller needs to know this; we could pick "3" as the
default, but it seemed just as easy the other way.
-dp
--
Daniel Price, Solaris Kernel Engineering http://blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
