publish_ips:

 - line 24: update copyright

 - line 35, et al: use double brackets

Both fixed.

 - line 80, et al: why not use $CHERRYPY_VER, et al, that we computed
   above?  Is it because you don't want to potentially have to force
   backpublishing every package whose version has changed?

I've opted to explicitly list the versions as the *_VER environment
variable isn't always the version we want.  An example here was the
dependency on SUNWpython-cherrypy, where we can specify a dependency on
3.1 to cover both 3.1.0 and 3.1.1 versions.

In addition, very earlier versions of SUNWipkg (like in 2008.05) had
incomplete incorporation support and so we want to be specific with the
build/branch id.

I've added a comment to this effect in the script.

Thanks for the review.
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to