Bart Smaalders wrote:
> http://cr.opensolaris.org/~barts/10476/
importer.py:
fetch_manifest() and fetch_catalog() both speak to making the client
transport API more user-friendly outside an image? Perhaps the image
module needs to define a dummy image that things like this can use?
(Not this wad, obviously.)
line 1175: no need for tuple()
line 1292: a tuple might be better than the string.
line 1293: return manifest_cache.setdefault(key, fetch_manifest(...))?
line 1326: similarly
line 1311: where are you writing to a file? Also, you don't explicitly
close the connection the way you do for the catalog.
line 1331: you could use the .clear() method to the dict, rather than
explicitly using global.
line 1373: no spaces around this equals
get_dependencies(): is it worth caching the results of the dependencies
based on server_url and each fmri? Seems like you could end up opening
a boatload of manifests over and over again.
line 1406: not needed
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
