On Thu, Aug 27, 2009 at 10:59:18AM -0700, John Sonnenschein wrote:

> http://cr.opensolaris.org/~error404/1463/

This looks fine.

> http://cr.opensolaris.org/~error404/516/

I'm curious why you didn't go farther with this fix.  The bug for 516
states that we would like to have the ability to log unexpected errors
in some other location.  The idea is that the output is intimidating to
casual users, but very useful for service and support.  516 cites 1498
and 1824 as possible ways to solve this problem.  It would be great if
you had the time to take some of our error handling a bit farther.

In terms of the fix itself, I mostly have nits:

api_errors.py:

  - line 120: I might re-write this as:

        Could not complete the operation: read-only filesystem.

        or

        A read-only filesystem prevented this operation from completing.

You also need to modify the api.py file to increase the API version
number.  There's also doc/client_api_versions.txt file that should be
changed to include a description of what was added in the new version.

After you putback this fix, you may want to file a bug against the GUI
so that they know to catch this exception too.

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to