John Sonnenschein wrote:
Greetings all
Could someone take a look at these for me?
http://cr.opensolaris.org/~error404/516/
There are definitely multiple paths where EROFS can occur beyond
execute_install, but I don't know if that's considered in or out of
scope for this bug.
modules/client/api_erorrs.py:
line 111: we generally place two newlines between class definitions
(although that has not been consistently enforced)
This should be a subclass of the PermissionsException so that
anywhere we catch a PermissionsException wouldn't have to be changed to
catch this specific case. In general, for client purposes, EROFS is no
different from EACCES in terms of failure.
A more descriptive name would be appreciated as Dan suggested.
http://cr.opensolaris.org/~error404/1463/
line 45: this test case needs a short description, we haven't always
been consistent about this, but it's quite helpful when a test fails and
you have to figure out what it's trying to do (without reading a related
bug)
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
