Brock Pytlik wrote:
Shawn Walker wrote:
Greetings,
[snip]

webrev:
http://cr.opensolaris.org/~swalker/pkg-cat-p2/

[snip]

Cheers,

client.py:
356: Is there a reason to use the string "known" here instead of a constant?
520: Why is the FileInUseException case being removed?

Now I remember why; because it is redundant. FileInUseException is a subclass of PermissionsExceptions, so isn't necessary given that there is already an exception handler for PermissionsException. I've removed it again ;)

Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to