Shawn Walker wrote:
Tom Mueller (plain-text) wrote:
Please review these changes for fixing bug 1530.
bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=1530
webrev: http://cr.opensolaris.org/~tmueller/ips-1530.1/
modules/client/image.py:
line 2731: this except is too broad; for example, I don't think you
want a KeyboardInterrupt at this point to cause a false negative; is
it really true that any exception here would be a signal that
permissions was the issue? The other concern I have here is that this
test doesn't account for images that cross filesystem boundaries. I
realise that's less likely at the moment, but it can happen.
I'll narrow this to OSErrors, etc. once I figure out what the
appropriate test should be. Please see the rest of the thread for that
discussion. The rest are fixed.
Thanks.
Tom
modules/client/imageplan.py:
lines 94-97: set()s would be better I think given that you just need
a unique list
tests/cli/testutils.py:
line 349: extra newline
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
