Shawn Walker wrote:
Tom Mueller (plain-text) wrote:
Tom Mueller (plain-text) wrote:
I've changed the code to try to set the owner and group to 0 as a
test as to whether a ownership change is possible. Also, I changed
the exception handling to just catch OSError, per Shawn's comment.
Also, I remerged with the gate, which means bumping the version to
21 since a previous checkin took 20.
New webrev here:
http://cr.opensolaris.org/~tmueller/ips-1530.2/
Any final comments on this. Shawn and Darren provided comments on
the initial review, but I haven't received anything on this update.
doc/client_api_versions.txt needs to be updated with a summary of your
changes.
I added the following at the top of the file:
Version 21:
Incompatible with clients using versions 0-19.
Changes:
The following exceptions were added to pkg.client.api_errors:
class UnknownUser(ActionExecutionError)
"""Used to indicate that an action has an owner tag that is
unknown."""
class UnknownGroup(ActionExecutionError)
"""Used to indicate that an action has an group tag that is
unknown."""
The ImageInterface.prepare method now can raise an ActionExecutionError.
modules/client/api.py:
line 91: It is true that you added new exceptions, but since they
are a subclass of an existing exception, which itself is a subclass of
ApiException, I don't think this is really incompatible with versions
19 and 20.
The reason for the incompatibility is because the ImageInterface.prepare
method can now raise an ActionExecutionError (either of the new
exceptions). It didn't raise this before. I modified the comment for
that method to include this exception in the list.
Thanks.
Tom
No other comments.
Cheers,
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
