Joanmarie Diggs wrote:
Hi John.

On Thu, 2009-09-03 at 16:04 +0100, jmr wrote:
Thanks Joanie, I have dropped the search label and put in grey text in the text field which sorts out 1.

Indeed it does. :-) It also seems to contradict the conclusion reached
in bug 7792. If that conclusion has since been revised, my apologies.
(Where does the UI spec live, anyway?)
Yep Jenya wanted us to put in the Search text in the text field, to be more conformant with Firefox and other apps with this type of search functionality. We do have the search icon beside the field which is pretty universal as a means of indicating search. We have tooltips on the controls and I thought these would be used by Orca so would be sufficient for visually impaired users. Is this not the case?

As I mentioned in the bug I will darken the grey text and ensure its restored when there is no user entered text.
The problem in your first webrev is that you changed the mnemonic widget
associated with the Search label:

@@ -441,25 +458,24 @@
                           <widget class="GtkLabel" id="label3">
                             <property name="visible">True</property>
                             <property name="events">GDK_POINTER_MOTION_MASK | 
GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
-                            <property name="label" 
translatable="yes">Se_arch:</property>
+                            <property name="no_show_all">True</property>
+                            <property name="xpad">6</property>
+                            <property name="label" 
translatable="yes">_Search:</property>
                             <property name="use_underline">True</property>
-                            <property 
name="mnemonic_widget">searchentry</property>
+                            <property 
name="mnemonic_widget">filtercombobox</property>
                           </widget>

Undo the final change above and Alt+S works as expected.
Thanks for that, my mistake.
I cannot reproduce 2.

Hmmmm.... The steps I provided reproduce the problem quite reliably for
me. And it happens on other, less predictable occasions as well. (And it
doesn't happen without your webrev.) If you, Padraig, and Michal cannot
reproduce it, I'll poke around in the code and see if I can work out
where it's failing.
I'll look into this again, but I did try several times to reproduce it and was unable to. I'll see if Michal or Padraig can reproduce it for me. I am on b118 I'll upgrade to b122 and see how it goes.
 and I have added support for Shift+F10 to bring up the right click menu.

Yea! Thank you!!
Yep you set us some interesting challenges ;)
Take care.
--joanie

I have changed the Search tooltip to be more helpful, but this might change depending on doc input from Jyothi and I have not yet implemented the default behavior for AND in the search (#8715), which I'll do tomorrow.

webrev:
http://cr.opensolaris.org/~jmr/pm_10401_layout_ui_cleanup_03Sep_355pm/

10401 PM Search, Source and Filter UI adjustments to align with usability feedback
11105 Usability feedback Rename Reload
11106 Simplify Status Bar info
11107 Double click should select a row
11108 Support right click popup menu in package list view.
11166 Better handling of search '*'
11167 Add initial grey search text to text field


JR

Joanmarie Diggs wrote:
Oops, one more nit. (Sorry!)

The new right-click popup menu seems to not be keyboard accessible.
(Shift+F10 should bring it up.)

--joanie

On Wed, 2009-09-02 at 13:48 -0400, Joanmarie Diggs wrote:
Hi John.

I totally dig the new tree view. That's awesome.

Couple of issues that jump out at me:

1. Alt S gives focus to the View combobox (unexpected, plus the 'S' in
the label for the Search entry is underlined).

2. Try the following:
    a. Launch PM
    b. Type a search term and press Return
    c. Click on All Categories (Search is cleared)
    d. Return focus to Search entry
    e. Repeat your search and press Return
--> f. Click on All Categories (Search is NOT cleared)
    g. Return focus to Search entry
    h. Click on All Categories (Search is cleared)

Take care.
--joanie

On Wed, 2009-09-02 at 17:57 +0100, jmr wrote:
Hi - here is a webrev that incorporates changes to the PM GUI based on usability studies in US and Poland. The most noticeable change is the move to a Category Tree view. There are additional usability changes to add, but I wanted to land this now to free up the glade file for other changes that need to be putback from Michal and Padraig.

webrev: http://cr.opensolaris.org/~jmr/pm_10401_layout_ui_cleanup_02Sep_550pm/

10401 PM Search, Source and Filter UI adjustments to align with usability feedback
11105 Usability feedback Rename Reload
11106 Simplify Status Bar info
11107 Double click should select a row
11108 Support right click popup menu in package list view.

JR
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to