Looks good to me.
Padraig
On 09/07/09 11:41, jmr wrote:
Thanks for the feedback Padraig - new webrev at:
webrev:
http://cr.opensolaris.org/~jmr/pm_10401_layout_ui_cleanup_07Sep_1130am/
Covers:
10401 PM Search, Source and Filter UI adjustments to align with
usability feedback
11105 Usability feedback Rename Reload
11106 Simplify Status Bar info
11107 Double click should select a row
11108 Support right click popup menu in package list view.
11166 Better handling of search '*'
11167 Add initial grey search text to text field
JR
Padraig O'Briain wrote:
Some comments in no particular order:
I may have missed this in previous emails but why is initial focus
changed from search entry field to publisher combo box?
This is the behavior in Firefox and Thunderbird, if I place focus in
the Search field you will not see the prompt text on initial startup,
which is what Jenya wanted originally.
The tooltip for the Search entry field is too cryptic for me. I have no
idea what it is trying to tell me.
Following suggestions from Jyothi and Ann will be dropping this back
to the original more generic one:
"Type text to search for the package."
A new search section is to be added at the top level in Help and more
examples added.
You have hardcoded colors for Search Text. Will there be an impact if
you change themes?
Checked in all themes including high contrast and inverse themes all
look fine.
The rest of the comments apply to packagemanager.py.
__on_applicationtreeview_button_press_event seems misnamed for
dealing with key press events.
Deals with both will change to:
__on_applicationtreeview_button_and_key_events
There are extra spaces at the end of line 374.
ok
There is one warning when pylint is run on packagemanager.py.
ok sorted, no warnings and rating at 10
I could not find where __toggle_search_text_mode is called.
removed
Indentation is 4 too many at line 1522.
Nope its 8 when using \ and if spanning a bracket then its 4.
Why is line 1879 changed?
Mixing set_text("") and delete_text(0,-1) so just making things more
consistent and readable
Line 2146 should be removed.
ok
I thought it was Shift+F10 to popup menu. I do not see any evidence
of Shift in the code.
Thanks added:
if not(event.state == gtk.gdk.SHIFT_MASK and
keyname == "F10"):
return
Typo at line 2243.
ok
Are there gtk.gdk constants you can use at lines 2266 and 2269?
GDK_2BUTTON_PRESS = 5 # gtk.gdk._2BUTTON_PRESS causes pylint
warning about accessing protected member
GDK_RIGHT_BUTTON = 3 # normally button 3 = right click, no enum
for this
What are the magic number 10, 15 at line 2280?
#Positions popup relative to the top left corner of the
currently
#selected row's Name cell
x, y = position
#Offset x by 10 and y by 15 so underlying
name is visible
Are you going to implement __on_applicationtreeview_motion_notify_event?
Not in this webrev, it will be in another one to add tooltips to the
status column cells.
Padraig
jmr wrote:
Joanie - all the testing you do for us is fantastic, really helps,
so no darts required ;)
Here's a new webrev with the change in the color of the Search
(Ctrl-F) prompt and it should now redisplay if the search field is
empty and it loses focus. I have noticed a few times where the focus
out event is not getting triggered and so the field stays blank, not
sure why that's happening, might be related to the issue you already
described. As I am no longer setting the focus in the search field
its just a minor annoyance, but I'd like to track it down.
webrev:
http://cr.opensolaris.org/~jmr/pm_10401_layout_ui_cleanup_04Sep_1145am/
Cheers,
JR
Joanmarie Diggs wrote:
Hi John.
On Thu, 2009-09-03 at 23:37 +0200, John Rice wrote:
Yep Jenya wanted us to put in the Search text in the text field,
to be more conformant with Firefox and other apps with this type
of search functionality. We do have the search icon beside the
field which is pretty universal as a means of indicating search.
We have tooltips on the controls and I thought these would be used
by Orca so would be sufficient for visually impaired users. Is
this not the case?
What you've done works splendidly with Orca (thank you for asking!!).
Not all visually impaired users (especially those with quite a bit of
usable vision) use Orca, however. That said, as I stated in the
bug, my
background is not UI design so I of course defer to all of y'all's
expertise.
As I mentioned in the bug I will darken the grey text and ensure
its restored when there is no user entered text.
Thanks. That should help quite a bit.
I'll look into this again, but I did try several times to
reproduce it and was unable to. I'll see if Michal or Padraig can
reproduce it for me. I am on b118 I'll upgrade to b122 and see how
it goes.
Oh, yeah, I should've mentioned that: I was on b121 and am just now
getting all of my systems updated to 122. My bad!
Yea! Thank you!!
Yep you set us some interesting challenges ;)
You've got the darts out again, don't you? ;-) ;-) ;-)
Thanks again, John. Take care.
--joanie
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
