Shawn Walker wrote:
The interoperability issues arise only when an offset into the file is calculated, as is done with the index files that are used for search. For this current usage with manifest files, using a text mode open is working fine.[email protected] wrote:Shawn,Thanks for the review. On Tue, Sep 29, 2009 at 03:47:42PM -0500, Shawn Walker wrote:* Should the "w" be "wb" where it is used?The previous code used "w" which is why I didn't bother to change it. The manifests are text.Yes, but the "b" ensures interoperability with Windows, et al. I just thought this would be a good time to fix that :)
For new code it is generally safer to read/write files in binary mode to avoid this issue.
Tom
<<attachment: Tom_Mueller.vcf>>
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
