On Tue, Sep 29, 2009 at 07:23:15AM +0100, Padraig O'Briain wrote:
> Sorry about that.
>
> Webrev is http://cr.opensolaris.org/~padraig/ips-11034-v3/.

Thanks for the URL.  I'm sorry it took me so long to respond.  I somehow
missed this message.

This change looks good.

It took me a moment to figure out what the code on 2785 was doing, and
why __do_exit always had to return true.  Given the interface for
timeout_add(), that makes sense.  I was curious how packagemanager
reduces the number of active threads once you set exiting = True.  Is it
that threads that may be running will see this value set and return
from the functions that check exiting?  Are there ever any situations
where you'll have a thread that's asleep?

Thanks,

-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to